Ignore some traits in shim layer #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of traits that should be ignored by nbclassic's shim layer.
open_browseris now a trait ofjupyter_server'sServerAppandExtensionApp. These traits must have the same name for backward-compatibility.log_levelandlog_formatexist inServerApp,ExtensionApp, andNotebookApp, and users need to be able to configure each one separately.This PR also changes the name trait of nbclassic's
NotebookAppto "notebook". This enables nbclassic to find thejupyter_notebook_config.py